RSCord/ServerSpacebarOld
Archived
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Start fresh when updating embeds for links

Browse Source 
In a previous commit I was attempting to be clever by only
replacing/removing embeds if necessary. This not only made the logic
more confusing but introduced a bug that would allow for orphaned
embeds when updating the search params of a URL.

This commit will remove all embeds that have a `.url` property and start
fresh. This simplifies the code and eliminates the aforementioned bug.
This commit is contained in:
Zane Helton 2025-06-28 03:17:09 -04:00 committed by Madeline
parent f9cfb46e73
commit 184433b078
1 changed files with 3 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
src/api/util/handlers/Message.ts
View File

@ -290,18 +290,13 @@ export async function postHandleMessage(message: Message) {
} }
} }
// Remove existing embeds whose URLs ARE in the current message (we'll regenerate them) // Remove ALL embeds that have URLs when processing links (start fresh)
data.embeds = data.embeds.filter((embed) => { data.embeds = data.embeds.filter((embed) => {
if (!embed.url) { if (!embed.url) {
return true; return true;
} }
try {
const normalizedEmbedUrl = normalizeUrl(embed.url); return false;
const shouldRemove = currentNormalizedUrls.has(normalizedEmbedUrl);
return !shouldRemove;
} catch {
return true;
}
}); });
const seenNormalizedUrls = new Set<string>(); const seenNormalizedUrls = new Set<string>();