Merge pull request #1360 from CyberL1/fix/application-command-code-fucks

fix: add BulkApplicationCommandCreateSchema

src/api/routes/applications/#application_id/commands/#command_id/index.ts

@@ -95,7 +95,7 @@ router.patch(
 			version: Snowflake.generate(),
 		};
 
-		await ApplicationCommand.update({ name: body.name }, commandForDb);
+		await ApplicationCommand.update({ name: body.name.trim() }, commandForDb);
 		res.send(commandForDb);
 	},
 );

src/api/routes/applications/#application_id/commands/index.ts

@@ -83,10 +83,10 @@ router.post(
 			version: Snowflake.generate(),
 		};
 
-		const commandExists = await ApplicationCommand.exists({ where: { application_id: req.params.application_id, name: body.name } });
+		const commandExists = await ApplicationCommand.exists({ where: { application_id: req.params.application_id, name: body.name.trim() } });
 
 		if (commandExists) {
-			await ApplicationCommand.update({ application_id: req.params.application_id, name: body.name }, commandForDb);
+			await ApplicationCommand.update({ application_id: req.params.application_id, name: body.name.trim() }, commandForDb);
 		} else {
 			commandForDb.id = Snowflake.generate(); // Have to be done that way so the id doesn't change
 			await ApplicationCommand.save(commandForDb);
@@ -99,7 +99,7 @@ router.post(
 router.put(
 	"/",
 	route({
-		// requestBody: "ApplicationCommandCreateSchema", // How to make this array?
+		requestBody: "BulkApplicationCommandCreateSchema",
 	}),
 	async (req: Request, res: Response) => {
 		const applicationExists = await Application.exists({ where: { id: req.params.application_id } });
@@ -154,10 +154,10 @@ router.put(
 				version: Snowflake.generate(),
 			};
 
-			const commandExists = await ApplicationCommand.exists({ where: { application_id: req.params.application_id, name: command.name } });
+			const commandExists = await ApplicationCommand.exists({ where: { application_id: req.params.application_id, name: command.name.trim() } });
 
 			if (commandExists) {
-				await ApplicationCommand.update({ application_id: req.params.application_id, name: command.name }, commandForDb);
+				await ApplicationCommand.update({ application_id: req.params.application_id, name: command.name.trim() }, commandForDb);
 			} else {
 				commandForDb.id = Snowflake.generate(); // Have to be done that way so the id doesn't change
 				await ApplicationCommand.save(commandForDb);

src/api/routes/applications/#application_id/guilds/#guild_id/commands/#command_id/index.ts

@@ -113,7 +113,7 @@ router.patch(
 		};
 
 		const commandExists = await ApplicationCommand.exists({
-			where: { application_id: req.params.application_id, guild_id: req.params.guild_id, id: req.params.command_id, name: body.name },
+			where: { application_id: req.params.application_id, guild_id: req.params.guild_id, id: req.params.command_id, name: body.name.trim() },
 		});
 
 		if (!commandExists) {
@@ -121,7 +121,10 @@ router.patch(
 			return;
 		}
 
-		await ApplicationCommand.update({ application_id: req.params.application_id, guild_id: req.params.guild_id, id: req.params.command_id, name: body.name }, commandForDb);
+		await ApplicationCommand.update(
+			{ application_id: req.params.application_id, guild_id: req.params.guild_id, id: req.params.command_id, name: body.name.trim() },
+			commandForDb,
+		);
 		res.send(commandForDb);
 	},
 );

src/api/routes/applications/#application_id/guilds/#guild_id/commands/index.ts

@@ -107,10 +107,10 @@ router.post(
 			version: Snowflake.generate(),
 		};
 
-		const commandExists = await ApplicationCommand.exists({ where: { application_id: req.params.application_id, guild_id: req.params.guild_id, name: body.name } });
+		const commandExists = await ApplicationCommand.exists({ where: { application_id: req.params.application_id, guild_id: req.params.guild_id, name: body.name.trim() } });
 
 		if (commandExists) {
-			await ApplicationCommand.update({ application_id: req.params.application_id, guild_id: req.params.guild_id, name: body.name }, commandForDb);
+			await ApplicationCommand.update({ application_id: req.params.application_id, guild_id: req.params.guild_id, name: body.name.trim() }, commandForDb);
 		} else {
 			commandForDb.id = Snowflake.generate(); // Have to be done that way so the id doesn't change
 			await ApplicationCommand.save(commandForDb);
@@ -123,7 +123,7 @@ router.post(
 router.put(
 	"/",
 	route({
-		// requestBody: "ApplicationCommandCreateSchema", // How to make this array?
+		requestBody: "BulkApplicationCommandCreateSchema",
 	}),
 	async (req: Request, res: Response) => {
 		const applicationExists = await Application.exists({ where: { id: req.params.application_id } });

src/api/routes/interactions/index.ts

@@ -91,7 +91,7 @@ router.post("/", route({}), async (req: Request, res: Response) => {
 	}
 
 	if (body.type === InteractionType.MessageComponent || body.data.type === InteractionType.ModalSubmit) {
-		interactionData.message = await Message.findOneOrFail({ where: { id: body.message_id } });
+		interactionData.message = await Message.findOneOrFail({ where: { id: body.message_id }, relations: ["author"] });
 	}
 
 	emitEvent({

src/schemas/api/bots/ApplicationCommandCreateSchema.ts

@@ -17,3 +17,5 @@ export interface ApplicationCommandCreateSchema {
 	contexts?: InteractionContextType[];
 	handler?: ApplicationCommandHandlerType;
 }
+
+export type BulkApplicationCommandCreateSchema = ApplicationCommandCreateSchema[];