From f48127f8a4881afc6dfb9b066b4eb357f1ef6c63 Mon Sep 17 00:00:00 2001
From: Flam3rboy <34555296+Flam3rboy@users.noreply.github.com>
Date: Wed, 7 Apr 2021 03:02:13 +0200
Subject: [PATCH] :bug: fix lean not working with virtuals

---
 package-lock.json     | Bin 69284 -> 70751 bytes
 package.json          |   1 +
 src/index.ts          |   4 +-
 src/models/Message.ts |  90 +++++++++++++++++++++---------------------
 src/models/index.ts   |  27 +++++++------
 src/util/Database.ts  |   9 +++++
 6 files changed, 72 insertions(+), 59 deletions(-)

diff --git a/package-lock.json b/package-lock.json
index 0e721c0c18ab3a77c6c71ceca11c0a7785cd4f20..902566edbd6800c95315a17f4b57583fe8d5f14e 100644
GIT binary patch
delta 693
zcmZ27m*xHnmJP=km2&g*()06+Q+0Dv6Z3S-GK)$|6LX4{tQ3^u4D?L(43%^y3rrW?
ze2$TyW%7bs@{>PaFr55=g=g~DTSCkRdM1+#1LVU(&C~o`l0%YH5`*2V0*$qEbAp{x
zQ<E|yi_B6J6O+9%jg1X_LVWyPGc1C0&2l5sN>h`~4HDD!LnE?%v=ejOa?K0U9JAaC
z(~`}zTob)qy~-Rt0w)`=m`%2d;GVpY)kYMnGbe8p7iBb<e89j6<Rl#oU+C-VW7Suz
zYcScLOF1mbFIzj%Co8}-EGpE*wb&~$-J~M0ILpT|(Zbm^S3lT0%B3>X*(lrB$iSl9
zv&g+P*DNK`#XQTz)W5LU)F3I`&poX$Dl(|lH6z2KBFfO*#XQlq9PDm~XwAv|OzfNQ
qvd)}D|8SF>{Pw5N<a1Zqq2Z@7Ie!NG5DP<u9~`1(Hs{YUEdu~#M)aKk

delta 32
qcmV+*0N?-Ls05^)1hB>dli&piv;6@N1heA^nUa&^2<o#NpG0-`%nsuK

diff --git a/package.json b/package.json
index 7900d301..b92228ff 100644
--- a/package.json
+++ b/package.json
@@ -28,6 +28,7 @@
 	},
 	"devDependencies": {
 		"@types/jsonwebtoken": "^8.5.0",
+		"@types/mongoose-lean-virtuals": "^0.5.1",
 		"@types/node": "^14.14.25",
 		"typescript": "^4.1.3"
 	}
diff --git a/src/index.ts b/src/index.ts
index 914431d8..343a7496 100644
--- a/src/index.ts
+++ b/src/index.ts
@@ -5,6 +5,6 @@ export * from "./models/index";
 export * from "./util/index";
 
 import Config, { DefaultOptions } from "./util/Config";
-import db, { MongooseCache } from "./util/Database";
+import db, { MongooseCache, toObject } from "./util/Database";
 
-export { Config, db, DefaultOptions, MongooseCache };
+export { Config, db, DefaultOptions, MongooseCache, toObject };
diff --git a/src/models/Message.ts b/src/models/Message.ts
index 15f00cf4..ee038f97 100644
--- a/src/models/Message.ts
+++ b/src/models/Message.ts
@@ -1,8 +1,9 @@
 import { Schema, Types, Document } from "mongoose";
 import db from "../util/Database";
-import { UserModel } from "./User";
-import { MemberModel } from "./Member";
-import { RoleModel } from "./Role";
+import { PublicUser, UserModel } from "./User";
+import { MemberModel, PublicMember } from "./Member";
+import { Role, RoleModel } from "./Role";
+import { Channel } from "./Channel";
 
 export interface Message {
 	id: string;
@@ -36,6 +37,12 @@ export interface Message {
 		channel_id?: string;
 		guild_id?: string;
 	};
+	// mongoose virtuals:
+	author?: PublicUser;
+	member?: PublicMember;
+	mentions?: PublicUser[];
+	mention_roles?: Role[];
+	mention_channels?: Channel[];
 }
 
 export interface MessageDocument extends Document, Message {
@@ -190,50 +197,39 @@ export const Embed = {
 	],
 };
 
-export const MessageSchema = new Schema(
-	{
-		id: String,
-		channel_id: String,
-		author_id: String,
-		webhook_id: String,
-		guild_id: String,
-		application_id: String,
-		content: String,
-		timestamp: Date,
-		edited_timestamp: Date,
-		tts: Boolean,
-		mention_everyone: Boolean,
-		mention_user_ids: [String],
-		mention_role_ids: [String],
-		mention_channel_ids: [String],
-		attachments: [Attachment],
-		embeds: [Embed],
-		reactions: [Reaction],
-		nonce: Schema.Types.Mixed, // can be a long or a string
-		pinned: Boolean,
-		type: { type: Number },
-		activity: {
-			type: Number,
-			party_id: String,
-		},
-		flags: Types.Long,
-		stickers: [],
-		message_reference: {
-			message_id: String,
-			channel_id: String,
-			guild_id: String,
-		},
+export const MessageSchema = new Schema({
+	id: String,
+	channel_id: String,
+	author_id: String,
+	webhook_id: String,
+	guild_id: String,
+	application_id: String,
+	content: String,
+	timestamp: Date,
+	edited_timestamp: Date,
+	tts: Boolean,
+	mention_everyone: Boolean,
+	mention_user_ids: [String],
+	mention_role_ids: [String],
+	mention_channel_ids: [String],
+	attachments: [Attachment],
+	embeds: [Embed],
+	reactions: [Reaction],
+	nonce: Schema.Types.Mixed, // can be a long or a string
+	pinned: Boolean,
+	type: { type: Number },
+	activity: {
+		type: Number,
+		party_id: String,
 	},
-	{
-		toJSON: {
-			transform: function (doc, ret) {
-				delete ret.mention_channel_ids;
-				delete ret.mention_user_ids;
-				delete ret.mention_role_ids;
-			},
-		},
-	}
-);
+	flags: Types.Long,
+	stickers: [],
+	message_reference: {
+		message_id: String,
+		channel_id: String,
+		guild_id: String,
+	},
+});
 
 MessageSchema.virtual("author", {
 	ref: UserModel,
@@ -270,6 +266,8 @@ MessageSchema.virtual("mention_channels", {
 	justOne: false,
 });
 
+MessageSchema.set("removeResponse", ["mention_channel_ids", "mention_role_ids", "mention_user_ids", "author_id"]);
+
 // TODO: missing Application Model
 // MessageSchema.virtual("application", {
 // 	ref: Application,
diff --git a/src/models/index.ts b/src/models/index.ts
index bb6024fe..03b9fe70 100644
--- a/src/models/index.ts
+++ b/src/models/index.ts
@@ -1,4 +1,20 @@
 import mongoose from "mongoose";
+import { Schema } from "mongoose";
+
+mongoose.plugin((schema: Schema, opts: any) => {
+	schema.set("toObject", {
+		virtuals: true,
+		versionKey: false,
+		transform(doc: any, ret: any) {
+			delete ret._id;
+			delete ret.__v;
+			const props = schema.get("removeResponse") || [];
+			props.forEach((prop: string) => {
+				delete ret[prop];
+			});
+		},
+	});
+});
 
 export * from "./Ban";
 export * from "./Channel";
@@ -15,14 +31,3 @@ export * from "./Message";
 export * from "./Status";
 export * from "./VoiceState";
 export * from "./Event";
-
-mongoose.plugin((schema: any) => {
-	schema.options.toJSON = {
-		virtuals: true,
-		versionKey: false,
-		transform(doc: any, ret: any) {
-			delete ret._id;
-			delete ret.__v;
-		},
-	};
-});
diff --git a/src/util/Database.ts b/src/util/Database.ts
index 883c8dcd..e17eeccb 100644
--- a/src/util/Database.ts
+++ b/src/util/Database.ts
@@ -2,6 +2,7 @@ import "./MongoBigInt";
 import mongoose, { Collection, Connection } from "mongoose";
 import { ChangeStream, ChangeEvent, Long } from "mongodb";
 import EventEmitter from "events";
+import { Document } from "mongoose";
 const uri = process.env.MONGO_URL || "mongodb://localhost:27017/fosscord?readPreference=secondaryPreferred";
 
 console.log(`[DB] connect: ${uri}`);
@@ -10,6 +11,14 @@ const connection = mongoose.createConnection(uri, { autoIndex: true, useNewUrlPa
 
 export default <Connection>connection;
 
+function transform<T extends Document>(document: T) {
+	return document.toObject({ virtuals: true });
+}
+
+export function toObject<T extends Document>(document: T | T[]) {
+	return Array.isArray(document) ? document.map((x) => transform<T>(x)) : transform(document);
+}
+
 export interface MongooseCache {
 	on(event: "delete", listener: (id: string) => void): this;
 	on(event: "change", listener: (data: any) => void): this;