add error handling inside the resource class

README.md

@@ -1,12 +1,17 @@
-# Roblox Legacy Patcher
+# <img src="https://git.randomserver.top/murdle/roblox-patcher/raw/branch/master/images/logo.png" width="32" height="32" /> Roblox Legacy Patcher
 ## What is this?
-This is an application which automatically downloads the latest version of Roblox Studio and makes it work on Windows 8.1 and below. It uses a wrapper in order to add some missing Windows APIs and trick Roblox into thinking your OS version is supported.
+This is a program which automatically downloads the latest version of Roblox Studio and makes it work on Windows 8.1 and below. It uses a wrapper in order to add some missing Windows APIs and trick Roblox into thinking your OS version is supported.
 
-## Notice
-Currently, the application only allows you to run Roblox Studio. Because of Roblox's anticheat (aka Hyperion), we have not been able to get the client to work as of right now.
+## Download
+You can download a prebuilt version of the program <a href="https://git.randomserver.top/murdle/roblox-patcher/releases">here</a>
+
+<img src="https://git.randomserver.top/murdle/roblox-patcher/raw/branch/master/images/preview.png" width="1000" height="800" />
 
 ## How to build
 - Install Visual Studio 2015 and .NET SDK 8
 - Clone the repository
 - Run the build.bat script
 <br>The built file will be located in the root of directory
+
+## Future plans
+Currently, the application only allows you to run Roblox Studio. Because of Roblox's anticheat (aka Hyperion), we have not been able to get the client to work as of right now. If we do get it to work, chances are the client hyperion bypass will be **closed source** to not suffer a similar fate to [Vinegar](https://vinegarhq.org/Home/rol_faq.html).

RobloxLegacy/Utilities/Registry.cs

@@ -2,7 +2,7 @@
 
 namespace RobloxLegacy.Utilities;
 
-public class Registry
+public static class Registry
 {
     private static RegistryKey? OpenKey(bool writable = true)
     {

RobloxLegacy/Utilities/Resource.cs

@@ -10,11 +10,11 @@ public class Resource(string name)
         return assembly.GetManifestResourceStream($"RobloxLegacy.Resources.{name}");
     }
     
-    public byte[]? GetBytes()
+    public byte[] GetBytes()
     {
         using var stream = GetStream();
         if (stream == null)
-            return null;
+            throw new Exception($"Failed to get {name} resource");
 
         using var ms = new MemoryStream();
         stream.CopyTo(ms);

RobloxLegacy/Utilities/Shortcut.cs

@@ -7,7 +7,6 @@ namespace RobloxLegacy.Utilities;
 // https://stackoverflow.com/a/14632782
 public static class Shortcut
 {
-
     [ComImport]
     [Guid("00021401-0000-0000-C000-000000000046")]
     private class ShellLink

RobloxLegacy/VersionManager.cs

@@ -58,8 +58,6 @@ public class VersionManager : IDisposable
     private void WriteAppSettings()
     {
         var appSettings = new Resource("AppSettings.xml").GetBytes();
-        if (appSettings == null)
-            throw new Exception("Failed to get AppSettings resource");
         File.WriteAllBytesAsync(Path.Combine(GetVersionPath(_currentVersion), "AppSettings.xml"), appSettings);
     }
     
@@ -73,8 +71,6 @@ public class VersionManager : IDisposable
         
         // now we can write the dll to the folder
         var dllContents = new Resource(DllName).GetBytes();
-        if (dllContents == null)
-            throw new Exception("Failed to get dll resource");
         File.WriteAllBytesAsync(Path.Combine(GetVersionPath(_currentVersion), DllName), dllContents);
     }
 

RobloxWrapper/RobloxWrapper/retarded-apis.cpp

@@ -0,0 +1 @@
+// more apis will be added here.